Skip to content

fix(slots): properly warn if slot invoked in setup #12195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 2, 2025
Merged

fix(slots): properly warn if slot invoked in setup #12195

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e91eebe
fix: update
Oct 17, 2024
41e10dc
chore: add test case
Oct 17, 2024
d7704f8
Merge branch 'main' into fix/renderSlotWarn
yangxiuxiu1115 Oct 17, 2024
4b1b14e
test: add basic warn case
Oct 17, 2024
e8e3cdf
chore: add test case
Oct 18, 2024
af6d2f6
chore: minor tweaks
edison1105 Oct 18, 2024
1591ac6
Merge branch 'main' into fix/renderSlotWarn
edison1105 Apr 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: add basic warn case
  • Loading branch information
yangchangtao committed Oct 17, 2024
commit 4b1b14e952fc6a6f3737fc711cea85e87b6b9ae7
20 changes: 20 additions & 0 deletions packages/runtime-core/__tests__/componentSlots.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,26 @@ describe('component: slots', () => {
).not.toHaveBeenWarned()
})

test('basic warn', () => {
const Comp = {
setup(_: any, { slots }: any) {
slots.default && slots.default()
return () => null
},
}

const App = {
setup() {
return () => h(Comp, () => h('div'))
},
}

createApp(App).mount(nodeOps.createElement('div'))
expect(
'Slot "default" invoked outside of the render function',
).toHaveBeenWarned()
})

test('should not warn when render in setup', () => {
const container = {
setup(_: any, { slots }: any) {
Expand Down