Editorial: Use new HTML activation model #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is refactor to use HTML's new activation model. The api currently uses transient activation.
|
@mgiuca, @ericwilligers, this is somewhat high-priority for getting the document published this week as FPWD. Happy to discuss or clarify anything - if we need to jump on quick hangout, also happy to do that. |
4 tasks
|
As we’ve been approved for publication by the W3C, and this change doesn’t make a substantive change, I’m going to merge this as it will otherwise the broken “triggered by user activation” link will block us from publishing until next year (I’m away until February). |
|
Thanks for checking it, @ericwilligers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is refactor to use HTML's new activation model. The api currently uses transient activation.
Details: whatwg/html#5129
In a new issue, we need to discuss if calling share should "consume" the activation.
Doing so might have the nice effect that we can get rid of the internal slot we added to protect against being able to call
.share()twice during the same activation phase.