Skip to content

BREAKING CHANGE: make share() consume user activation #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 17, 2020
Merged

BREAKING CHANGE: make share() consume user activation #137

merged 3 commits into from
Jun 17, 2020

Conversation

marcoscaceres
Copy link
Member

@marcoscaceres marcoscaceres commented Dec 13, 2019 •
edited by ewilligers
Loading

Closes #136

For normative changes, the following tasks have been completed:

  • Modified Web platform tests (link to pull request)

Implementation commitment:

@marcoscaceres marcoscaceres mentioned this pull request Dec 13, 2019
Closed
@marcoscaceres
Copy link
Member Author

Blocked on #135 (it includes 135, so that should be merged first).

@marcoscaceres marcoscaceres marked this pull request as ready for review December 17, 2019 11:38
@marcoscaceres marcoscaceres requested a review from mgiuca December 17, 2019 11:39
@marcoscaceres
Copy link
Member Author

This is no longer blocked.

@marcoscaceres
Copy link
Member Author

This is now unblocked... @mgiuca and @ericwilligers, what are your thoughts on supporting this? Seems fairly logical that we would consume the activation here, given that on most platforms this is a modal dialog.

@marcoscaceres marcoscaceres requested a review from ewilligers May 14, 2020 10:16
mgiuca
mgiuca approved these changes May 15, 2020
View reviewed changes
Copy link
Collaborator

@mgiuca mgiuca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Arguably the note in security & privacy is not necessary. I don't think user activation requirement is considered to be a security mitigation, just fixes user annoyance. I would probably drop that.

@marcoscaceres
Copy link
Member Author

Filed Gecko bug to implement this.

@marcoscaceres
Copy link
Member Author

marcoscaceres commented Jun 4, 2020 •
edited
Loading

Ok great... about the test, I see some testing suggestions in the Chrome bug. Should we try to come up with a WPT test together? Like we could check against some other API we all implement that also consumes the activation.

marcoscaceres and others added 3 commits June 12, 2020 18:37
@marcoscaceres
Editorial: use new HTML activation model
e34e1d4 
This is refactor to use HTML's new activation model. The
api currently uses transient activation.
@marcoscaceres
BREAKING CHANGE: make share() consume user activation
3ecdbf0
@marcoscaceres
Drop note as per @mgiuca's suggestion
a3dec08
@marcoscaceres
Copy link
Member Author

Ok, I'm about ready to land this in Gecko including updated Web Platform Tests. https://phabricator.services.mozilla.com/D79640

I'd expect them to show up in WPT in about 72 hours.

@marcoscaceres marcoscaceres merged commit f62dc29 into master Jun 17, 2020
@marcoscaceres marcoscaceres deleted the consume branch June 17, 2020 10:20
@marcoscaceres marcoscaceres mentioned this pull request Oct 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgiuca mgiuca mgiuca approved these changes

@ewilligers ewilligers ewilligers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should calling share() "consume" the activation?
3 participants
@marcoscaceres @mgiuca @ewilligers