Avoid the term "valid URL string". #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
urlfield does not need to be a valid URL string (i.e., a string that when run through the URL parser, does not produce any validation error). It only needs to be a string that when run through the URL parser, does not produce failure.There doesn't appear to be any term for this (which is kind of nuts, since this concept is literally the only thing that ever matters in any place on the web where a URL is expected). I'll just say "URL string".
(This used to be a well-defined term, until whatwg/url@50cb9ab9d8 😕)
Preview | Diff