Skip to content

fix: add getTransactionId method to the SynthesizeStream #1058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2020

Conversation

dpopp07
Copy link
Contributor

@dpopp07 dpopp07 commented Sep 24, 2020

This method was present on the RecognizeStream and was mistakenly left off of the SynthesizeStream when it was developed. This PR fixes that mistake.

Rather than duplicate the method between the Stream classes, I moved the core functionality to a utility function that each Stream relies on. No code has actually changed; it works exactly the same.

this method was present on the RecognizeStream and was mistakenly left off of the SynthesizeStream
@apaparazzi0329
Copy link
Contributor

I have already tested this and it works as expected. 👍🏼

Copy link
Contributor

@apaparazzi0329 apaparazzi0329 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@dpopp07 dpopp07 merged commit 21a5a7f into master Sep 25, 2020
@dpopp07 dpopp07 deleted the dp/synth-stream-get-transaction-id branch September 25, 2020 18:05
watson-github-bot pushed a commit that referenced this pull request Sep 29, 2020
## [5.7.1](v5.7.0...v5.7.1) (2020-09-29)

### Bug Fixes

* add `getTransactionId` method to the SynthesizeStream ([#1058](#1058)) ([21a5a7f](21a5a7f))
* stop ignoring serviceUrl for Websocket methods ([#1060](#1060)) ([1901aae](1901aae))
@watson-github-bot
Copy link
Collaborator

🎉 This PR is included in version 5.7.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants