Skip to content

fix: stop ignoring serviceUrl for Websocket methods #1060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2020
Merged

fix: stop ignoring serviceUrl for Websocket methods #1060

merged 1 commit into from
Sep 29, 2020

Conversation

dpopp07
Copy link
Contributor

@dpopp07 dpopp07 commented Sep 28, 2020 •
edited
Loading

The Websocket methods recognizeUsingWebsocket (STT) and synthesizeUsingWebsocket (TTS) were not using the serviceUrl parameter defined by the core. They were only looking for url.

The serviceUrl parameter is the correct one, url is deprecated (but still supported). In the core, serviceUrl and url are both mapped to baseOptions.serviceUrl, so we only need to look at that single parameter and both are supported. This is a compatible change. I updated the test to make sure the user can provide both serviceUrl and url.

Resolves #1059

@dpopp07
fix: stop ignoring serviceUrl for Websocket methods
b59044a 
`recognizeUsingWebsocket` (STT) and `synthesizeUsingWebsocket` (TTS) were not using the `serviceUrl` parameter defined by the core
apaparazzi0329
apaparazzi0329 approved these changes Sep 29, 2020
View reviewed changes
Copy link
Contributor

@apaparazzi0329 apaparazzi0329 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes fix the issue stated and are good to go 👍🏼

@dpopp07 dpopp07 merged commit 1901aae into master Sep 29, 2020
@dpopp07 dpopp07 deleted the dp/fix-speech-service-configs branch September 29, 2020 16:30
watson-github-bot pushed a commit that referenced this pull request Sep 29, 2020
@semantic-release-bot
chore(release): 5.7.1 [skip ci]
51dcfdc 
## [5.7.1](v5.7.0...v5.7.1) (2020-09-29)

### Bug Fixes

* add `getTransactionId` method to the SynthesizeStream ([#1058](#1058)) ([21a5a7f](21a5a7f))
* stop ignoring serviceUrl for Websocket methods ([#1060](#1060)) ([1901aae](1901aae))
@watson-github-bot
Copy link
Collaborator

🎉 This PR is included in version 5.7.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@henriquebonfim henriquebonfim mentioned this pull request Aug 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apaparazzi0329 apaparazzi0329 apaparazzi0329 approved these changes

Assignees
No one assigned
Labels
released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

recognizeUsingWebSocket does not support serviceUrl initialization parameter
3 participants
@dpopp07 @watson-github-bot @apaparazzi0329