Disallow streaming upload on HTTP/1.1 connections #1444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to reduce the risk to break existing HTTP/1.1 servers.
annevk
reviewed
May 30, 2022
|
Thanks @yutakahirano! Happy to merge this once #1438 concludes. |
domenic
reviewed
Jun 1, 2022
Closed
|
@yutakahirano from the discussion in #1438 it appears this is the only remaining change needed to the specification. Do we have test coverage for this feature now that's adequate? It seems that we could even test this particular code path. Mozilla can be considered supportive of this change. Mozilla never had much of an interest to support HTTP/1.1. |
|
Thank you! I have a chromium-side CL that updates WPT. https://chromium-review.googlesource.com/c/chromium/src/+/3699531 |
annevk
approved these changes
Jun 16, 2022
|
I decided to merge this to reduce the number of things we have in flight. But to be clear, as noted in #1438 the final design of upload streams isn't settled yet. Thanks @yutakahirano for working on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to reduce the risk to break existing HTTP/1.1 servers.
See #966, #1438.
(See WHATWG Working Mode: Changes for more details.)
Preview | Diff