Skip to content

Disallow streaming upload on HTTP/1.1 connections #1444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 16, 2022
Merged

Disallow streaming upload on HTTP/1.1 connections #1444

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ad59ede
Disallow streaming upload on HTTP/1.1 connections
yutakahirano May 30, 2022
2ed8ed2
fix
yutakahirano Jun 1, 2022
829c52e
found some other chunked text that can also go now
annevk Jun 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions fetch.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5434,11 +5434,9 @@ optional boolean <var>forceNewConnection</var> (default false), run these steps:
<a for="fetch timing info">post-redirect start time</a>, and <var>fetchParams</var>'s
<a for="fetch params">cross-origin isolated capability</a>.

<li><p>If <var>connection</var> is not an HTTP/2 connection, <var>request</var>'s
<li><p>If <var>connection</var> is an HTTP/1.x connection, <var>request</var>'s
<a for=request>body</a> is non-null, and <var>request</var>'s <a for=request>body</a>'s
<a for=body>source</a> is null, then <a for="header list">append</a>
(`<code>Transfer-Encoding</code>`, `<code>chunked</code>`) to <var>request</var>'s
<a for=request>header list</a>.
<a for=body>source</a> is null, then return a <a>network error</a>.

<li>Set <var>timingInfo</var>'s <a for="fetch timing info">final network-request start time</a>
to the <a for=/>coarsened shared current time</a> given <var>fetchParams</var>'s
Expand Down Expand Up @@ -5512,10 +5510,6 @@ optional boolean <var>forceNewConnection</var> (default false), run these steps:
therefore <var>response</var> represents both a <a for=/>response</a> and
an HTTP response here.

<p>If <var>request</var>'s <a for=request>header list</a> contains
(`<code>Transfer-Encoding</code>`, `<code>chunked</code>`) and <var>response</var> is
transferred via HTTP/1.0 or older, then return a <a>network error</a>.

<p>If the HTTP request results in a TLS client certificate dialog, then:

<ol>
Expand Down