Skip to content

Conversation

tbursztyka
Copy link
Contributor

Frame format was validated, but its length should be also validated
relevantly against the format.

Fixes #24970

Signed-off-by: Tomasz Bursztyka [email protected]

Copy link
Contributor

@rlubos rlubos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, verified on nRF52840, works well.

@tbursztyka
Copy link
Contributor Author

thanks @rlubos

@tbursztyka tbursztyka marked this pull request as ready for review May 6, 2020 10:20
@tbursztyka tbursztyka requested a review from jukkar as a code owner May 6, 2020 10:20
Copy link
Member

@jukkar jukkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, minor nit

Frame format was validated, but its length should be also validated
relevantly against the format.

Fixes zephyrproject-rtos#24970

Signed-off-by: Tomasz Bursztyka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ieee802154 l2: no length check in frame validation
5 participants