Skip to content

Conversation

zephyrbot
Copy link

Backport 38970c07abfcddcfc6a5958189f096a55c49594a~1..38970c07abfcddcfc6a5958189f096a55c49594a from #24971

Frame format was validated, but its length should be also validated
relevantly against the format.

Fixes #24970

Signed-off-by: Tomasz Bursztyka <[email protected]>
@d3zd3z d3zd3z requested a review from tbursztyka March 17, 2021 21:23
@galak
Copy link
Contributor

galak commented Apr 13, 2021

Can you rebase now that the doc building is fixed.

@d3zd3z
Copy link
Contributor

d3zd3z commented Apr 20, 2021

@galak

Can you rebase now that the doc building is fixed.

This appears to already be after the fix. Both docs and kite are failing.

@d3zd3z
Copy link
Contributor

d3zd3z commented Apr 20, 2021

Regardless, I don't seem to be able to push to this branch anyway:

remote: error: GH006: Protected branch update failed for refs/heads/backport-24971-to-v1.14-branch.
remote: error: Cannot force-push to this protected branch
To https://github.com/zephyrproject-rtos/zephyr
 ! [remote rejected]       backport-24971-to-v1.14-branch -> backport-24971-to-v1.14-branch (protected branch hook declined)
error: failed to push some refs to 'https://github.com/zephyrproject-rtos/zephyr'

@github-actions
Copy link

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@ceolin
Copy link
Member

ceolin commented Jul 23, 2021

CI failure is not related with this PR is an issue with TIMESLICEs that was fixed in completely different and related pr.

@ceolin ceolin self-requested a review July 23, 2021 21:52
@ceolin
Copy link
Member

ceolin commented Jul 23, 2021

@tbursztyka can you review this backport please ?

@nashif nashif merged commit afe7553 into v1.14-branch Aug 30, 2021
@nashif nashif deleted the backport-24971-to-v1.14-branch branch October 29, 2021 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants