Skip to content

msglist: Cut excess spacing between sender and paragraph #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 1, 2024
Merged

msglist: Cut excess spacing between sender and paragraph #542

merged 1 commit into from
Mar 1, 2024

Conversation

chrisbobbe
Copy link
Collaborator

@chrisbobbe chrisbobbe commented Mar 1, 2024 •
edited by gnprice
Loading

This is the "easy hack" Greg mentions in the description of #513.

Fixes: #513

@chrisbobbe chrisbobbe added the a-msglist The message-list screen, except what's label:a-content label Mar 1, 2024
@chrisbobbe
Copy link
Collaborator Author

Before After
image image

@chrisbobbe
Copy link
Collaborator Author

(I didn't mark this with Fixes: because it doesn't do the "fixing this properly" thing that you described in the issue.)

@gnprice
Copy link
Member

gnprice commented Mar 1, 2024

Thanks!

I think this can actually be best described as fixing #513. This does fix the excess spacing, just in a way that potentially goes too far for certain content. And the work that it leaves open is basically part of #162.

@chrisbobbe @gnprice
msglist: Cut excess spacing between sender and paragraph
b20d84e 
This is the "easy hack" Greg mentions in the description of zulip#513.

Fixes: zulip#513
@gnprice gnprice force-pushed the pr-sender-excess-spacing branch from 1db7298 to b20d84e Compare March 1, 2024 00:31
@gnprice gnprice merged commit b20d84e into zulip:main Mar 1, 2024
@gnprice
Copy link
Member

gnprice commented Mar 1, 2024

Looks good; merging, after that metadata tweak.

@chrisbobbe chrisbobbe deleted the pr-sender-excess-spacing branch March 1, 2024 01:34
@chrisbobbe
Copy link
Collaborator Author

Cool, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
a-msglist The message-list screen, except what's label:a-content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Excess spacing between sender and paragraph
2 participants
@chrisbobbe @gnprice