[pull] main from microsoft:main #7

pull · 2021-05-17T22:36:56Z

See Commits and Changes for more details.

Can you help keep this open source service alive? 💖 Please sponsor : )

coveralls · 2021-05-17T22:50:19Z

Pull Request Test Coverage Report for Build 4198805761

2638 of 3152 (83.69%) changed or added relevant lines in 397 files are covered.
31 unchanged lines in 21 files lost coverage.
Overall coverage decreased (-0.8%) to 84.656%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
libraries/adaptive-expressions/src/builtinFunctions/merge.ts	22	23	95.65%
libraries/adaptive-expressions/src/converters/enumExpressionConverter.ts	9	10	90.0%
libraries/adaptive-expressions/src/functionUtils.ts	19	20	95.0%
libraries/adaptive-expressions/src/memory/simpleObjectMemory.ts	0	1	0.0%
libraries/adaptive-expressions/src/triggerTrees/quantifier.ts	0	1	0.0%
libraries/botbuilder-ai/src/luisAdaptiveRecognizer.ts	2	3	66.67%
libraries/botbuilder-ai/src/qnaCardBuilder.ts	13	14	92.86%
libraries/botbuilder-ai/src/qnamaker-utils/generateAnswerUtils.ts	10	11	90.91%
libraries/botbuilder-applicationinsights/src/applicationInsightsTelemetryClient.ts	0	1	0.0%
libraries/botbuilder-azure/src/cosmosDbKeyEscape.ts	6	7	85.71%

Files with Coverage Reduction	New Missed Lines	%
libraries/adaptive-expressions/src/converters/enumExpressionConverter.ts	1	73.08%
libraries/botbuilder-azure-blobs/src/sanitizeBlobKey.ts	1	4.76%
libraries/botbuilder-core/src/skills/skillConversationIdFactory.ts	1	17.39%
libraries/botbuilder-core/src/testAdapter.ts	1	89.68%
libraries/botbuilder-dialogs-adaptive/src/actions/codeAction.ts	1	21.05%
libraries/botbuilder-dialogs-adaptive/src/actions/forEachPage.ts	1	72.29%
libraries/botbuilder-dialogs-adaptive/src/actions/sendHandoffActivity.ts	1	20.0%
libraries/botbuilder-dialogs-adaptive/src/actions/telemetryTrackEventAction.ts	1	52.0%
libraries/botbuilder-dialogs-adaptive/src/templates/activityTemplate.ts	1	84.0%
libraries/botbuilder-dialogs-adaptive/src/templates/textTemplate.ts	1	80.0%

Totals
Change from base Build 843368398:	-0.8%
Covered Lines:	20013
Relevant Lines:	22404

💛 - Coveralls

…estify 10.0.0+ (#4429) * Add next callback to support restify chain handler * Update next type and channelServiceRoutes tests * Remove return next() to fix Headers Sent Error * Add return next() in the handler function

…ing requests on disconnection (#4461) * Fix inconclusive tests * Rejects pending requests on disconnection * isConnected should always return boolean * Fix race condition of missed responses * Add client/server tests * Skip test if it is not on Windows * Fix for Node.js 12 * Fix and skip failing tests

* Add MeetingTabIconSurface to MeetingSurface capabilities * Add updated schema --------- Co-authored-by: Corina Gum <>

…4471) * Fix telemetry activityId and conversationId properties * Fix when responses come empty

Bumps [vm2](https://github.com/patriksimek/vm2) from 3.9.11 to 3.9.17. - [Release notes](https://github.com/patriksimek/vm2/releases) - [Changelog](https://github.com/patriksimek/vm2/blob/master/CHANGELOG.md) - [Commits](patriksimek/vm2@3.9.11...3.9.17) --- updated-dependencies: - dependency-name: vm2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…4436) * Add expired token exception and tests * Fix depcheck issues * Fix failing test.

…ot (#4402) Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2. - [Release notes](https://github.com/json5/json5/releases) - [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md) - [Commits](json5/json5@v1.0.1...v1.0.2) --- updated-dependencies: - dependency-name: json5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2. - [Release notes](https://github.com/json5/json5/releases) - [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md) - [Commits](json5/json5@v1.0.1...v1.0.2) --- updated-dependencies: - dependency-name: json5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [ua-parser-js](https://github.com/faisalman/ua-parser-js) from 0.7.31 to 0.7.33. - [Release notes](https://github.com/faisalman/ua-parser-js/releases) - [Changelog](https://github.com/faisalman/ua-parser-js/blob/master/changelog.md) - [Commits](faisalman/ua-parser-js@0.7.31...0.7.33) --- updated-dependencies: - dependency-name: ua-parser-js dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…edentials (never CertificateAppCredentials) -- certificate auth flow broken (#4457) * Add support for certificates * Fix typos

Bumps [cookiejar](https://github.com/bmeck/node-cookiejar) from 2.1.2 to 2.1.4. - [Release notes](https://github.com/bmeck/node-cookiejar/releases) - [Commits](https://github.com/bmeck/node-cookiejar/commits) --- updated-dependencies: - dependency-name: cookiejar dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* add onBehalfOf property to Teams channel * fix code requirements --------- Co-authored-by: JhontSouth <[email protected]>

* Update nyc dependency * Fix tools nyc coverage reference

…PartitionedStorage (#4473) * add tokenCredential authentication to cosmosDB * fix ts issues with new version * fix pipelines issues * add EOF --------- Co-authored-by: JhontSouth <[email protected]>

Bumps [vm2](https://github.com/patriksimek/vm2) from 3.9.17 to 3.9.18. - [Release notes](https://github.com/patriksimek/vm2/releases) - [Changelog](https://github.com/patriksimek/vm2/blob/master/CHANGELOG.md) - [Commits](patriksimek/vm2@3.9.17...3.9.18) --- updated-dependencies: - dependency-name: vm2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add logic to qnaCardBuilder.ts to generate adaptive card for Teams * Set adaptive card width to full * Add optional bool variable for adaptive card and remove separate function * Refactor new code into methods and add comments * Fix linting issues * Update botbuilder-ai.api.md * Fix remaining linting issues * Address requested changes * Create qnaMakerDialogAdaptiveCard.test.js * Update getSuggestionsCard to use adaptive card and update qna dialog tests to use the new parameter * Update generated docs * Update botbuilder-ai.api.md --------- Co-authored-by: Anish Prasad <[email protected]>

…bility (#4477) * Updates fast-xml-parser * rename function

…on (#4486) * Add MSI authentication in blobsStorage * Update unit tests for blobsStorage constructor

Bumps [fast-xml-parser](https://github.com/NaturalIntelligence/fast-xml-parser) from 4.2.2 to 4.2.4. - [Release notes](https://github.com/NaturalIntelligence/fast-xml-parser/releases) - [Changelog](https://github.com/NaturalIntelligence/fast-xml-parser/blob/master/CHANGELOG.md) - [Commits](https://github.com/NaturalIntelligence/fast-xml-parser/commits) --- updated-dependencies: - dependency-name: fast-xml-parser dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add expired token exception and tests * Fix depcheck issues * Fix failing test. * Log exception and unit test to check message added * Log and unit test updated. * Applied suggested changes --------- Co-authored-by: CeciliaAvila <[email protected]> Co-authored-by: JhontSouth <[email protected]> Co-authored-by: Emiliano Quiroga <[email protected]> Co-authored-by: Cecilia Avila <[email protected]>

* Add support for config auth type (fetch & submit) * Fix typings for ConfigResponse config type (@template) * Apply PR comments to rename invoke handlers * add unit tests for config auth type (fetch & submit) * rebuild api docs * Rename config handlers & fix invoke response types * Add updated schema * Apply PR feedback * Add PR changes --------- Co-authored-by: Corina Gum <>

Co-authored-by: Tracy Boehrer <[email protected]>

* fix activity locale overwriting * add overwriting test * fix package json format * remove only tag and format code --------- Co-authored-by: JhontSouth <[email protected]>

Co-authored-by: JhontSouth <[email protected]>

Bumps [semver](https://github.com/npm/node-semver) from 7.3.8 to 7.5.2. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/main/CHANGELOG.md) - [Commits](npm/node-semver@v7.3.8...v7.5.2) --- updated-dependencies: - dependency-name: semver dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix eslint issues in botbuilder-azure-queues * remove eslint config * remove eslint-plugin-only-warn

* fix eslint issues in botbuilder-dialogs * add eslint config file * combine unit tests and remove duplicated * initialize this.endReason

* fix ESLint issues in botbuilder-ai-orchestrator * Merge branch 'southworks/update/eslint-packages' into southworks/fix/eslint-issues-botbuilder-ai-orchestrator * remove eslint config file * update yarn.lock

Bumps [nanoid](https://github.com/ai/nanoid) from 3.3.6 to 3.3.8. - [Release notes](https://github.com/ai/nanoid/releases) - [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md) - [Commits](ai/nanoid@3.3.6...3.3.8) --- updated-dependencies: - dependency-name: nanoid dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: CeciliaAvila <[email protected]>

* initial commit * add export for middleware * update api file * update api file again * update core api * update botbuilder api * address comments * Fix lint issues * Update botbuilder.api.md --------- Co-authored-by: bentsai <[email protected]> Co-authored-by: CeciliaAvila <[email protected]>

…or (#4847)

* Fix remaining ESLint issues * Fix platform specific slash

…en' unit test (#4848) * add fake expired token * remove base64url * fix lint issue

* update p-map and apply tsup configurations * fix missing space * add p-map to depcheck ignore * fix lint issues with vendors * modify ignores order * format list * add vendors to files list

Co-authored-by: Tracy Boehrer <[email protected]>

* update chai and applied tsup formats * ignore packages in depcheck * remove chai dependencies

* Update empty bot templates * Update echo bot templates * Remove core bot templates and its references * Fix unit tests

Bumps [elliptic](https://github.com/indutny/elliptic) from 6.6.0 to 6.6.1. - [Commits](indutny/elliptic@v6.6.0...v6.6.1) --- updated-dependencies: - dependency-name: elliptic dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Migrate deprecated core-http to new libraries * Fix ESLint * Remove unused dependency * Fix node_modules pathing * Remove unused folder declaration * Fix TypeScript modifying .js and .d.ts files * Fix eslint

…ialized with process.env (#4857) * Fix config options type to support process.env * Fix eslint * Fix test:compat

Bumps [axios](https://github.com/axios/axios) from 1.7.7 to 1.8.2. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md) - [Commits](axios/axios@v1.7.7...v1.8.2) --- updated-dependencies: - dependency-name: axios dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Co-authored-by: Cecilia Avila <[email protected]>

* initial commit * update api md file --------- Co-authored-by: bentsai <[email protected]>

Bumps [tar-fs](https://github.com/mafintosh/tar-fs) from 2.1.1 to 2.1.2. - [Commits](mafintosh/tar-fs@v2.1.1...v2.1.2) --- updated-dependencies: - dependency-name: tar-fs dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

pull bot added the ⤵️ pull label May 17, 2021

trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Jun 18, 2021

Anish Prasad and others added 27 commits February 16, 2023 14:36

feat: Add MeetingTabIconSurface to MeetingSurface capabilities (#4459)

561d438

* Add MeetingTabIconSurface to MeetingSurface capabilities * Add updated schema --------- Co-authored-by: Corina Gum <>

Update and remove unnecessary done function calls (#4468)

d086767

fix: [#4466] Fix telemetry activityId and conversationId properties (#…

c3c1bf1

…4471) * Fix telemetry activityId and conversationId properties * Fix when responses come empty

Add call to save state in Set Property actions (#4472)

dba563d

port: [#4432] Expired JWT token exception not being handled (#6572) (#…

3fe6730

…4436) * Add expired token exception and tests * Fix depcheck issues * Fix failing test.

fix: [#4449] CloudAdapter always builds Connector with MicrosoftAppCr…

60b3f98

…edentials (never CertificateAppCredentials) -- certificate auth flow broken (#4457) * Add support for certificates * Fix typos

port: [#4463][#6596] TeamsChannelData need OnBehalfOf (#4474)

04a6175

* add onBehalfOf property to Teams channel * fix code requirements --------- Co-authored-by: JhontSouth <[email protected]>

bump: Update tools/nyc dependency (#4475)

b110344

* Update nyc dependency * Fix tools nyc coverage reference

port: [#4465][#6560] Allow TokenCredential authentication in CosmosDb…

192d4b2

…PartitionedStorage (#4473) * add tokenCredential authentication to cosmosDB * fix ts issues with new version * fix pipelines issues * add EOF --------- Co-authored-by: JhontSouth <[email protected]>

fix: Updates fast-xml-parser to address "Prototype Pollution" vulnera…

1b967e3

…bility (#4477) * Updates fast-xml-parser * rename function

feat: [#4446] Azure Blob Storage should support Identity authenticati…

5cc55f1

…on (#4486) * Add MSI authentication in blobsStorage * Update unit tests for blobsStorage constructor

Dropped Node 12 from builds (#4501)

3b0352e

Co-authored-by: Tracy Boehrer <[email protected]>

port: [#4481] Outgoing Activity Locale being Overwritten (#4489)

6cae128

* fix activity locale overwriting * add overwriting test * fix package json format * remove only tag and format code --------- Co-authored-by: JhontSouth <[email protected]>

Add userId property to Language Service QnA (#4493)

a44bfbc

Co-authored-by: JhontSouth <[email protected]>

JhontSouth and others added 30 commits January 6, 2025 09:05

fix: ESLint issues in botbuilder-azure-queues (#4831)

d5d82e6

* fix eslint issues in botbuilder-azure-queues * remove eslint config * remove eslint-plugin-only-warn

fix: ESLint issues in botbuilder-dialogs (#4832)

5464ddd

* fix eslint issues in botbuilder-dialogs * add eslint config file * combine unit tests and remove duplicated * initialize this.endReason

fix eslint issues in adaptive expressions (#4833)

7cafc93

remove eslint configuration (#4835)

bb2bf0f

fix eslint issues in botframework-schema (#4836)

050ee9f

fix: ESLint issues in bobuilder-ai-orchestrator (#4837)

9198d2a

* fix ESLint issues in botbuilder-ai-orchestrator * Merge branch 'southworks/update/eslint-packages' into southworks/fix/eslint-issues-botbuilder-ai-orchestrator * remove eslint config file * update yarn.lock

fix eslint issues in botbuilder-repo-utils (#4838)

75ed816

update nightwatch (#4816)

4bac80c

update path-to-regexp dependency (#4817)

4c055b7

update d3-format and use it with tsup (#4842)

428a1cd

Run the coveralls step only for windows (#4843)

adca2e0

add the support for every possible issuer in Single Tenant for emulat…

b3b1f65

…or (#4847)

fix: Remaining ESLint issues (#4846)

7b1434f

* Fix remaining ESLint issues * Fix platform specific slash

port: [#6882] Mock expired token for 'throws exception on expired tok…

62112c0

…en' unit test (#4848) * add fake expired token * remove base64url * fix lint issue

bump: Update p-map package (#4820)

29ae34b

* update p-map and apply tsup configurations * fix missing space * add p-map to depcheck ignore * fix lint issues with vendors * modify ignores order * format list * add vendors to files list

Suppress fake secret in unit test. (#4850)

4a9c741

Co-authored-by: Tracy Boehrer <[email protected]>

bump: Update chai package (#4844)

7534989

* update chai and applied tsup formats * ignore packages in depcheck * remove chai dependencies

Fix actions/cache deprecation (#4858)

87d0ad1

fix: Update generators and remove Core Bot templates (#4867)

66578b0

* Update empty bot templates * Update echo bot templates * Remove core bot templates and its references * Fix unit tests

refactor: [#4759] Migrate off @azure/core-http (#4834)

157e1e7

* Migrate deprecated core-http to new libraries * Fix ESLint * Remove unused dependency * Fix node_modules pathing * Remove unused folder declaration * Fix TypeScript modifying .js and .d.ts files * Fix eslint

Update elliptic, esbuild, and serialize-javascript (#4862)

b8501c6

fix: [#4853] ConfigurationBotFrameworkAuthentication errors when init…

702a41f

…ialized with process.env (#4857) * Fix config options type to support process.env * Fix eslint * Fix test:compat

Allow null value for Configuration parameter (#4856)

bac622b

Update babel-runtime (#4868)

44128f0

Co-authored-by: Cecilia Avila <[email protected]>

fix: Add signInSso cardviewType to SignInCardViewParameters (#4872)

2612216

* initial commit * update api md file --------- Co-authored-by: bentsai <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[pull] main from microsoft:main #7

[pull] main from microsoft:main #7

Uh oh!

pull bot commented May 17, 2021 •

edited

Loading

Uh oh!

coveralls commented May 17, 2021 •

edited

Loading

Uh oh!

Uh oh!

[pull] main from microsoft:main #7

Are you sure you want to change the base?

[pull] main from microsoft:main #7

Uh oh!

Conversation

pull bot commented May 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented May 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 4198805761

💛 - Coveralls

Uh oh!

Uh oh!

pull bot commented May 17, 2021 •

edited

Loading

coveralls commented May 17, 2021 •

edited

Loading