Skip to content

Make remove_reflect parameter names consistent between ReflectCommandExt and impl for EntityCommands #19243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Make remove_reflect parameter names consistent between ReflectCommandExt and impl for EntityCommands #19243

wants to merge 2 commits into from

Conversation

theotherphil
Copy link
Contributor

Objective

Fix #13390

Solution

The second parameter of the remove_reflect function is called component_type_name in ReflectCommandExt but component_type_path in the implementation for EntityCommands. Use component_type_path in both places.

Testing

None

@theotherphil theotherphil added the C-Docs An addition or correction to our documentation label May 16, 2025
@MrGVSV MrGVSV added D-Trivial Nice and easy! A great choice to get started with Bevy A-ECS Entities, components, systems, and events A-Reflection Runtime information about types S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels May 16, 2025
@MrGVSV
Copy link
Member

MrGVSV commented May 16, 2025

We should probably update its documentation to replace "type name" with "type path" as well.

Vrixyz
Vrixyz approved these changes May 17, 2025
View reviewed changes
Copy link
Member

@Vrixyz Vrixyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving :)

Usually when we see "path" in rust, there is a custom type representing the Path so it can be broken into different parts, but that's way outside of this PR, I'm just dumping my thoughts here :)

@Vrixyz Vrixyz added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels May 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vrixyz Vrixyz Vrixyz approved these changes

@MrGVSV MrGVSV MrGVSV approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events A-Reflection Runtime information about types C-Docs An addition or correction to our documentation D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

variable in reflect_remove method in ReflectExt trait has wrong naming and wrong docs description
3 participants
@theotherphil @MrGVSV @Vrixyz