Skip to content

Make remove_reflect parameter names consistent between ReflectCommandExt and impl for EntityCommands #19243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Make remove_reflect parameter names consistent between ReflectCommandExt and impl for EntityCommands #19243

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea8f644
Make remove_reflect parameter names consistent between ReflectCommand…
theotherphil May 16, 2025
7d95c91
type name -> type path in docs
theotherphil May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions crates/bevy_ecs/src/reflect/entity_commands.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ pub trait ReflectCommandExt {
component: Box<dyn PartialReflect>,
) -> &mut Self;

/// Removes from the entity the component or bundle with the given type name registered in [`AppTypeRegistry`].
/// Removes from the entity the component or bundle with the given type path registered in [`AppTypeRegistry`].
///
/// If the type is a bundle, it will remove any components in that bundle regardless if the entity
/// contains all the components.
Expand Down Expand Up @@ -159,12 +159,12 @@ pub trait ReflectCommandExt {
/// .remove_reflect(prefab.data.reflect_type_path().to_owned());
/// }
/// ```
fn remove_reflect(&mut self, component_type_name: impl Into<Cow<'static, str>>) -> &mut Self;
fn remove_reflect(&mut self, component_type_path: impl Into<Cow<'static, str>>) -> &mut Self;
/// Same as [`remove_reflect`](ReflectCommandExt::remove_reflect), but using the `T` resource as type registry instead of
/// `AppTypeRegistry`.
fn remove_reflect_with_registry<T: Resource + AsRef<TypeRegistry>>(
&mut self,
component_type_name: impl Into<Cow<'static, str>>,
component_type_path: impl Into<Cow<'static, str>>,
) -> &mut Self;
}

Expand Down Expand Up @@ -263,7 +263,7 @@ impl<'w> EntityWorldMut<'w> {
self
}

/// Removes from the entity the component or bundle with the given type name registered in [`AppTypeRegistry`].
/// Removes from the entity the component or bundle with the given type path registered in [`AppTypeRegistry`].
///
/// If the type is a bundle, it will remove any components in that bundle regardless if the entity
/// contains all the components.
Expand Down