Skip to content

feat: Support Node 24 #16236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 8, 2025
Merged

feat: Support Node 24 #16236

merged 4 commits into from
May 8, 2025

Conversation

AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad requested a review from a team May 8, 2025 15:12
@AbhiPrasad AbhiPrasad self-assigned this May 8, 2025
@AbhiPrasad AbhiPrasad requested review from Lms24, chargome and timfish and removed request for a team May 8, 2025 15:12
@timfish
Copy link
Collaborator

timfish commented May 8, 2025

The new unit test failure is horrible 🤯

 FAIL  test/integrations/google-cloud-http.test.ts [ test/integrations/google-cloud-http.test.ts ]
TypeError: Cannot read properties of undefined (reading 'prototype')
 ❯ Object.<anonymous> ../../node_modules/buffer-equal-constant-time/index.js:37:35
 ❯ Object.<anonymous> ../../node_modules/jwa/index.js:1:19

@AbhiPrasad
Copy link
Member Author

AbhiPrasad commented May 8, 2025

We're running into two issues:

  1. Google Cloud Serverless Node 24 Unit Tests: https://github.com/getsentry/sentry-javascript/actions/runs/14913821156/job/41895096782?pr=16236
⎯⎯⎯⎯⎯⎯ Failed Suites 1 ⎯⎯⎯⎯⎯⎯⎯

 FAIL  test/integrations/google-cloud-http.test.ts [ test/integrations/google-cloud-http.test.ts ]
TypeError: Cannot read properties of undefined (reading 'prototype')
 ❯ Object.<anonymous> ../../node_modules/buffer-equal-constant-time/index.js:37:35
 ❯ Object.<anonymous> ../../node_modules/jwa/index.js:1:19

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/1]⎯

 Test Files  1 failed | 5 passed (6)
      Tests  31 passed (31)
   Start at  19:01:43
   Duration  3.99s (transform 1.32s, setup 0ms, collect 7.68s, tests 151ms, environment 2ms, prepare 787ms)
  1. Remix Node 24 Tests: https://github.com/getsentry/sentry-javascript/actions/runs/14913821156/job/41895096659?pr=16236
SyntaxError: The requested module '@sentry/core' does not provide an export named 'Event'
SyntaxError: The requested module '@sentry/core' does not provide an export named 'Event'
SyntaxError: The requested module '@sentry/core' does not provide an export named 'Event'
SyntaxError: The requested module '@sentry/core' does not provide an export named 'Event'
SyntaxError: The requested module '@sentry/core' does not provide an export named 'Event'
SyntaxError: The requested module '@sentry/core' does not provide an export named 'Event'
SyntaxError: The requested module '@sentry/core' does not provide an export named 'Event'
SyntaxError: The requested module '@playwright/test' does not provide an export named 'Page'

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
ERROR: "test:integration:client:ci" exited with 1.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Not sure why this is failing now - stale reference? I'll try clearing CI first.

@AbhiPrasad
Copy link
Member Author

Disabled Remix node 24 integration tests and google cloud serverless unit tests on Node 24 to unblock merging this in.

Will create two issues to follow up on this, but we should try to get this released asap!

@AbhiPrasad AbhiPrasad merged commit 5dd37a6 into develop May 8, 2025
156 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-node-24 branch May 8, 2025 20:43
@github-actions github-actions bot mentioned this pull request May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node 24 Support
2 participants