Fix wrong context menu argument from FileSystem's item list #106040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
added
bug
topic:editor
topic:plugin
cherrypick:4.4
KoBeWi
force-pushed
the
paths_stored_as_integer_lol
branch
from
2801953 to
0b5230b
Compare
akien-mga
approved these changes
Jun 22, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EditorContextMenuPlugin is supposed to receive list of paths for FileSystem's callback.
It works when clicking the option, but it's broken when using the shortcut, but only in ItemList. The method was wrongly receiving a list of selected item IDs.
This PR fixes it and improves
_file_list_get_selected()method.