Vulkan Mobile: Fix lightmap instances count #106907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpockBauru
changed the title
AThousandShips
added
bug
topic:rendering
cherrypick:4.4
|
Makes sense to me, it now works the same way as in the clustered renderer. My only concern is whether this was intentional or accidental, and if this affects performance negatively. The comments in the mobile renderer suggest that the lightmap system was meant to be reworked at some point, but that never happened, so I'm curious if this was implemented as a temporary workaround to some potential performance issues. |
SpockBauru
force-pushed
the
fix-mobile-lightmap-instances
branch
from
33ffa6b to
7aee6e2
Compare
|
Rebased after the awesome (and massive) SHADER BAKER!!! |
SpockBauru
force-pushed
the
fix-mobile-lightmap-instances
branch
from
7aee6e2 to
fe1d499
Compare
clayjohn
approved these changes
Jun 11, 2025
|
Thanks! |
|
Thanks everyone! If this PR is going to be cherry picked for 4.4 do not forget to also cherrypick #106748, it's just one line of moved code ^-^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #106906
The max instances of LightmapGI is hardcoded with the magic number 2 instead of using the appropriate enum
MAX_LIGHTMAPS. This PR fixes it.It only works because @BlueCube3310 fixed the
_fill_render_listinitialization in #106748. That PR not only fixes the editor but also several bugs like lightmap flickering when loading/unloading in runtime.MRP: lightmap-bug.zip
4.5.dev4
lightmap_bug.mp4
This PR
lightmap_bug_fix.mp4