Skip to content

Improve auto-translation of editor's top & bottom bars #107624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025

Conversation

timothyqiu
Copy link
Member

@timothyqiu timothyqiu commented Jun 17, 2025

Part of #104574

Cleaned up auto translation for:

  • The main menu
  • The run bar
  • The rendering method selector tooltip
  • The update spinner
  • The bottom panel buttons

@timothyqiu timothyqiu added this to the 4.x milestone Jun 17, 2025
@timothyqiu timothyqiu requested review from a team as code owners June 17, 2025 12:00
@timothyqiu timothyqiu requested review from a team as code owners June 17, 2025 12:00
@timothyqiu timothyqiu requested a review from a team as a code owner June 17, 2025 12:00
@timothyqiu timothyqiu removed request for a team June 17, 2025 12:01
@akien-mga akien-mga modified the milestones: 4.x, 4.5 Jun 18, 2025
@KoBeWi
Copy link
Member

KoBeWi commented Jun 18, 2025

I don't see any code that would update renderer names after language change. Is it oversight or you plan to add it later? (it doesn't seem easy to do)

- The main menu
- The run bar
- The update spinner
- The bottom panel buttons
@timothyqiu
Copy link
Member Author

I don't see any code that would update renderer names after language change. Is it oversight or you plan to add it later? (it doesn't seem easy to do)

Ah yes, I'll make a separate PR for the rendering methods dropdown.

Updated. Removed those rendering method selector changes that are meaningless from the perspective of this PR.

@Repiteo Repiteo merged commit c825fcf into godotengine:master Jun 18, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Jun 18, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants