Skip to content

[3.x] ResourceImporterWAV: Detect if data chunk size is larger than the actual size #107694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 22, 2025

Conversation

DeeJayLSP
Copy link
Contributor

@DeeJayLSP DeeJayLSP commented Jun 19, 2025

Backport of #97711

Fixes #40320

@DeeJayLSP DeeJayLSP requested a review from a team as a code owner June 19, 2025 03:07
@DeeJayLSP DeeJayLSP force-pushed the 3.x-fix-large-wav branch from ab8b534 to e3c7082 Compare June 19, 2025 03:10
@DeeJayLSP DeeJayLSP changed the title [3.x] Fix freeze when data chunk size in WAV header is larger than the actual size [3.x] ResourceImporterWAV: Detect if data chunk size is larger than the actual size Jun 19, 2025
@DeeJayLSP DeeJayLSP force-pushed the 3.x-fix-large-wav branch from e3c7082 to 57159bc Compare June 19, 2025 03:21
@AThousandShips AThousandShips added this to the 3.7 milestone Jun 19, 2025
@AThousandShips AThousandShips added bug topic:audio topic:import crash cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release cherrypick:3.6 Considered for cherry-picking into a future 3.6.x release labels Jun 19, 2025
@akien-mga akien-mga merged commit b61a7a2 into godotengine:3.x Jun 22, 2025
14 checks passed
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.6.1.

@akien-mga akien-mga removed the cherrypick:3.6 Considered for cherry-picking into a future 3.6.x release label Jun 23, 2025
@DeeJayLSP DeeJayLSP deleted the 3.x-fix-large-wav branch June 23, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release crash topic:audio topic:import
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants