Skip to content

FTI - Add reset on setting top_level #108112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2025

Conversation

lawnjelly
Copy link
Member

@lawnjelly lawnjelly commented Jun 29, 2025

Fixes #108086

I've labelled 4.5, but it's really up to production whether to push this to 4.6 as it is easily get aroundable, and is more an enhancement than bug fix, so feel free to push to 4.6.

Notes

  • Although reset_physics_interpolation() will cure this (as with any teleport), I think this should be fine for adding an auto-reset, I can't think of any situation where you'd want to toggle top_level and not perform a reset.
  • I've taken the opportunity to check the new SceneTree::is_fti_enabled() static function to make reset_physics_interpolation() super cheap to call when FTI is off.
  • Also applicable to 3.x.

Copy link
Member

@rburing rburing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this behavior is desired in 100% of cases.

Copy link
Contributor

@Repiteo Repiteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this is technically an enhancement, but in practice this is in-line with other bugfixes we've merged this cycle, so I'm comfortable including it

@Repiteo Repiteo merged commit 9228354 into godotengine:master Jul 1, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Jul 1, 2025

Thanks!

@lawnjelly lawnjelly deleted the fti_toplevel_resets branch July 2, 2025 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting a 3D node as top_level with physics interpolation on make it interpolate from its old local transform
3 participants