Skip to content

Plain name IRI fragments can use unicode #1359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

handrews
Copy link
Contributor

@handrews handrews commented Dec 6, 2022

Fixes #1314 as discussed in yesterday's community call. This just brings plain name fragment support into parity with the rest of our IRI support, and continues to rely on XML's NCName rule for the syntax. NCName always supported unicode, we just excluded all of it except for the US-ASCII characters.

I think I converted the W3C's grammar notation into ABNF properly, but if anyone is comfortable with ABNF (@awwright ?) a check would be appreciated. The W3C's grammar involves NCName, NCNameChar, and NCStartNameChar, which are just Name, NameChar, and StartNameChar minus the : character. I simplified the ABNF since we did not need the : variation at all.

Copy link
Member

@jdesrosiers jdesrosiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather not include the NCName reproduction, but I don't feel strongly enough about it to ask for it to change. Consider it a suggestion and I'm ok with keeping others want to see it included.

@awwright
Copy link
Member

awwright commented Dec 17, 2022

@handrews Like this:

NCName          = NCNameStartChar *NCNameChar

NCNameStartChar = "_" / ALPHA
                / %xC0-D6 / %xD8-F6 / %xF8-2FF
                / %x370-37D / %x37F-1FFF
                / %x200C-200D / %x2070-218F
                / %x2C00-2FEF / %x3001-D7FF
                / %xF900-FDCF / %xFDF0-FFFD
                / %x10000-EFFFF

NCNameChar      = NCNameStartChar / "-" / "." / DIGIT
                / %xB7 / %x0300-036F / %x203F-2040

However if we're not going to use ABNF for making a normative requirement, then maybe it'd be better to just give the regular expression. Or both.

@gregsdennis
Copy link
Member

Replaced by ☝️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expand plain name fragments to unicode / IRIs
4 participants