-
Notifications
You must be signed in to change notification settings - Fork 373
Fix: Reset both sec and nanosec in time_from_start #1709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Reset both sec and nanosec in time_from_start #1709
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1709 +/- ##
=======================================
Coverage 85.69% 85.70%
=======================================
Files 123 123
Lines 11895 11896 +1
Branches 1014 1014
=======================================
+ Hits 10194 10195 +1
Misses 1379 1379
Partials 322 322
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I had a quick look to find a one-line assignment, but there is also none in rclcpp::duration.
483d6ac
into
ros-controls:master
(cherry picked from commit 483d6ac)
(cherry picked from commit 483d6ac)
Co-authored-by: Arnav Kapoor <[email protected]>
Co-authored-by: Arnav Kapoor <[email protected]>
Fixes issue #1708 by resetting both seconds and nanoseconds in
time_from_start
.Previously, only seconds were reset with
set__sec(0)
, but nanoseconds remained unchanged, causing incorrect time resets.This patch sets both
sec
andnanosec
to zero explicitly.