Develop new reset params reacher walker pushblock #2322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentpierre
approved these changes
Jul 24, 2019
| @@ -13,6 +14,8 @@ public class ReacherAgent : Agent { | |||
| private Rigidbody rbB; | |||
| private float goalSpeed; | |||
| private float goalSize; | |||
| private float deviation; | |||
There was a problem hiding this comment.
A comment here and there to define what those parameters do
| @@ -0,0 +1,13 @@ | |||
| %YAML 1.1 | |||
There was a problem hiding this comment.
Should this file really be in the SharedAssets folder ? It is called PushBlockGround so I would put in the PushBlock folder...
There was a problem hiding this comment.
I actually don't think this file is used anywhere.
ervteng
approved these changes
Jul 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reset Parameters implemented for Pushblock, Reacher and Walker
Pushblock: dynamic_friction, static_friction, block_drag, block_scale
Reacher: Gravity, non-linear goal movement
Walker: Gravity, torso mass