[animations] fix invalid text style names #103
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution. I am going to close this PR in favor of #109, which includes the same change and some more. |
stuartmorgan-g
pushed a commit
that referenced
this pull request
Oct 31, 2024
* pushing all local work 7.6 * The rest of the files * applies mask to every node in group, started including clip node * Solves issue when of when mask's path nodes are embedded * Applies mask in visitPathnode, quits optimizing if stroke property set or empty intersection * some unit tests added * last test * Added path_ops to deps * Removed unused imports * fixed merge * tweaks: c * initial commit for ClippingOptimizer * .. * ... * fixed all issues from PR * .. * Added tests * ... * visitChildren * fixed PR round 2 issues * Update packages/vector_graphics_compiler/lib/src/svg/parser.dart Co-authored-by: Dan Field <[email protected]> * .. * removes hard coded pathOps path * fixed analysis issue * fixed enum issue * fixed ci issue * Update packages/vector_graphics_compiler/lib/src/svg/path_ops.dart Co-authored-by: Dan Field <[email protected]> * removed masking optimizer from parser.dart * Update packages/vector_graphics_compiler/test/masking_optimizer_test.dart Co-authored-by: Jonah Williams <[email protected]> * Update packages/vector_graphics_compiler/lib/src/svg/masking_optimizer.dart Co-authored-by: Jonah Williams <[email protected]> * fixed some issues * fixed issues * fixe d * fixed test string * Update packages/vector_graphics_compiler/lib/src/svg/masking_optimizer.dart Co-authored-by: Jonah Williams <[email protected]> * removed dart core import * fixed import * ..." " * added command line maskingoptimizer flag fixed path ops dylib issue * . * .. * . * fixed dylib issue in masking_optimizer_test * fixed dylib issue in parser test * adds optimize-clips command line flag, allows for dylib to be loaded when needed for clipping optimier * removed ArgConfig * Update main.dart * Update end_to_end_test.dart * . * fixed ci issue * adds named parameters, fixes some of parser tests * All parser tests fixed * moved ffi components into separate file * fix named parameter * .. * updated parser tests * fixed formatting * Update packages/vector_graphics_compiler/lib/src/svg/clipping_optimizer.dart Co-authored-by: Dan Field <[email protected]> * Update packages/vector_graphics_compiler/test/clipping_optimizer_test.dart Co-authored-by: Jonah Williams <[email protected]> * fixed all PR issues * fixed dylib loading issue in end_to_end_test.dart * removing un needed path_ops variables Co-authored-by: Dan Field <[email protected]> Co-authored-by: Jonah Williams <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed invalid textStyle name from textThemes used in the sample project