Skip to content

Use Flutter stable for testing, format, and analysis #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Use Flutter stable for testing, format, and analysis #108

wants to merge 1 commit into from

Conversation

creativecreatorormaybenot
Copy link
Contributor

The analyisis (and other) runs on flutter channel master which causes problems:

Both of these are failing in CI checks, even though they would not fail on stable. This also means that something like the animations example does not even work on stable because it uses members from master. Still, the checks did not complain.

@goderbauer
Copy link
Member

I don't think we should only test on stable. It will be important for us to also know that these work with master...

@creativecreatorormaybenot
Copy link
Contributor Author

creativecreatorormaybenot commented Feb 21, 2020

@goderbauer I agree. Still, is it not more important that they run on stable primarily? The example (#103) does not run on stable at all.

@goderbauer
Copy link
Member

I don't think any of these channels is more important than any of the others. Many people ship their app from the dev or master channel...

@gspencergoog
Copy link
Contributor

@creativecreatorormaybenot, I'm going to close this PR not because your point isn't valid (it is!), but because we think this particular approach would cause more problems than it would solve right now. Instead, if you could, please file an issue that describes the problem and we'll try and find a more universal solution.

@creativecreatorormaybenot
Copy link
Contributor Author

@gspencergoog flutter/flutter#51540

@creativecreatorormaybenot creativecreatorormaybenot deleted the use-stable-analysis branch February 27, 2020 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants