[animations] Fix analyzer warnings #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shihaohong
changed the title
goderbauer
reviewed
Feb 21, 2020
| @@ -5,6 +5,7 @@ version: 0.0.1 | |||
|
|
|||
| environment: | |||
| sdk: ">=2.3.0 <3.0.0" | |||
| flutter: ^1.15.3 | |||
There was a problem hiding this comment.
This will make pub mad because that version doesn't exist yet (from pub's point of view).
|
See also my comment here: #106 (comment) |
goderbauer
reviewed
Feb 21, 2020
packages/animations/CHANGELOG.md
Outdated
| * Fix a typo in the changelog dates | ||
| * Add a note to the README that the `animations` package is not currently | ||
| compatible with Flutter's `stable` branch. | ||
|
|
There was a problem hiding this comment.
Include that the example app has been switched back to the old style material stuff to be compatible with stable for now.
added 2 commits
February 21, 2020 09:44
shihaohong
changed the title
added 2 commits
February 21, 2020 09:48
shihaohong
changed the title
shihaohong
changed the title
added 2 commits
February 21, 2020 10:02
goderbauer
approved these changes
Feb 21, 2020
| // TODO(shihaohong): Re-implement the @override annotation once Flutter stable | ||
| // contains https://github.com/flutter/flutter/pull/48274. | ||
| // ignore: annotate_overrides | ||
|
|
There was a problem hiding this comment.
nit: remove extra blank line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to be compatible with Flutter's
stablebranch for the time being.until Flutter's stable branch contains Implement reverseTransitionDuration for TransitionRoute flutter#48274.