Skip to content

[animations] Remove unnecessary override #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[animations] Remove unnecessary override #106

wants to merge 1 commit into from

Conversation

creativecreatorormaybenot
Copy link
Contributor

reverseTransitionDuration in TransitionRoute is only added in v1.15.3 and Flutter stable is at v1.12.13+hotfix.8.

Thus, the @override annotation should not exist currently (analyzer is complaining).

@creativecreatorormaybenot creativecreatorormaybenot changed the title Remove unnecessary override [animations] Remove unnecessary override Feb 21, 2020
@shihaohong
Copy link

The issue with commenting out the @OverRide annotation here is that it will break the Material transitions as well (tests will fail because the transitions are technically incorrect going in the reverse direction).

cc/ @goderbauer Has a scenario like this ever happened before? The best answer I can come up with is to wait for the reverse duration feature to hit the master branch.

@goderbauer
Copy link
Member

What is the failure mode when you use the library with the current stable of Flutter? Is it just the analyzer complaining and the reverseDuration gets ignored in favor of the regular duration? In that case I'd suggest doing nothing and just waiting for the next stable release.

@creativecreatorormaybenot
Copy link
Contributor Author

@goderbauer I see. So should I close this then?

@goderbauer
Copy link
Member

Yeah, I think we should just close this since this has no real impact for users of the package. If the analyzer warning bothers you, we could add a a dart // ignore: to that line with a TODO to remove it when that change hits stable.

@goderbauer
Copy link
Member

@shihaohong is adding that // ignore: in #109. I am going to close this PR in favor of that one.

@goderbauer goderbauer closed this Feb 21, 2020
@creativecreatorormaybenot creativecreatorormaybenot deleted the remove-override branch February 21, 2020 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants