Skip to content

Conversation

aliberts
Copy link
Collaborator

@aliberts aliberts commented Feb 29, 2024

ℹ️ Run poetry install and then pre-commit install to add pre-commits hooks

Added pre-commit

  • Line-length: 110 (to be adjusted here if needed)
  • Ran styler on all files
  • Fixed style issues whenever possible
  • Added # noqa otherwise (N812, N807, N806, N802, B023)
  • Updated README

Questions

@aliberts aliberts requested a review from Cadene February 29, 2024 12:59
if not _has_gym:
raise ImportError("Cannot import gym.")

from diffusion_policy.env.pusht.pusht_env import PushTEnv
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave as TODO (PushTEnv is similar to PushTImageEnv, but without the image rendering, it's faster to iterate on)

Copy link
Collaborator

@Cadene Cadene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aliberts aliberts merged commit cb7b375 into main Feb 29, 2024
@aliberts aliberts deleted the pre-commit branch March 3, 2024 11:53
alexander-soare pushed a commit that referenced this pull request May 27, 2024
RussTedrake pushed a commit to RussTedrake/lerobot that referenced this pull request Jul 8, 2024
Fixing a couple of VQ-BeT bugs, working with multiple images.
@jess-moss jess-moss mentioned this pull request Sep 3, 2024
1 task
menhguin pushed a commit to menhguin/lerobot that referenced this pull request Feb 9, 2025
menhguin pushed a commit to menhguin/lerobot that referenced this pull request Feb 9, 2025
LeoLin6 pushed a commit to LeoLin6/lerobot that referenced this pull request Aug 14, 2025
michel-aractingi pushed a commit that referenced this pull request Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants