-
Notifications
You must be signed in to change notification settings - Fork 13
Instance affinity groups on settings tab #2767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I suggest either group or name for the first column label. Do you think an entire tab gives it undue prominence. Especially since most instances are unlikely to be part of one. There are consequences to over-encouraging users to use affinity groups with live upgrade and I think the shape of the UI affects the ways in which users will consider the frequency to use it. Then again I'm not a fan of conditionally rendering UI, because it's confusing for the use when it's not there. Is there some commonality with auto-restart where we move them onto the same tab. Or just shift it into settings. The auto-restart one would need to be full width and the input partially widthed to accomodate. |
I'll fix the column header. Yeah, I could see putting it on settings. Good idea. I don't think giving it its own tab is necessarily bad either — we would have to make the empty state make clear that you don't need it unless you know you need it. |
I wonder if the opposite would look better? As in full width but add a |
fc6ffd6
to
4d719d7
Compare
</div> | ||
{children} | ||
</div> | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately git can't tell this is almost entirely a move. The only change is taking off width="medium"
and putting max-w-lg
on the ListboxField
.
4d719d7
to
29c7580
Compare
oxidecomputer/console@72e2f0c...f52f50c * [f52f50c7](oxidecomputer/console@f52f50c7) react 19.1 * [d0999667](oxidecomputer/console@d0999667) oxidecomputer/console#2773 * [e7bfb236](oxidecomputer/console@e7bfb236) oxidecomputer/console#2767 * [59e69764](oxidecomputer/console@59e69764) oxidecomputer/console#2768 * [44157459](oxidecomputer/console@44157459) oxidecomputer/console#2770 * [5a90b430](oxidecomputer/console@5a90b430) oxidecomputer/console#2769 * [c12696c0](oxidecomputer/console@c12696c0) make api-diff use latest generator * [5538906c](oxidecomputer/console@5538906c) oxidecomputer/console#2760 * [653ba4cb](oxidecomputer/console@653ba4cb) bump omicron for instance affinity groups list * [179f347f](oxidecomputer/console@179f347f) oxidecomputer/console#2766 * [dbaeb3d3](oxidecomputer/console@dbaeb3d3) oxidecomputer/console#2765 * [549c266e](oxidecomputer/console@549c266e) oxidecomputer/console#2762 * [d41ef17f](oxidecomputer/console@d41ef17f) oxidecomputer/console#2763 * [a5804f8f](oxidecomputer/console@a5804f8f) oxidecomputer/console#2761 * [fb2fdbec](oxidecomputer/console@fb2fdbec) oxidecomputer/console#2759 * [9de391c8](oxidecomputer/console@9de391c8) chore: playwright 1.51.1 came out like an hour later * [b49f70c0](oxidecomputer/console@b49f70c0) oxidecomputer/console#2757 * [3eb24d2d](oxidecomputer/console@3eb24d2d) chore: bump playwright to 1.51 * [f29e4ea9](oxidecomputer/console@f29e4ea9) chore: bump vite + plugins, vitest, msw * [0f3408d0](oxidecomputer/console@0f3408d0) chore: bump oxlint to 0.16 * [f9931e03](oxidecomputer/console@f9931e03) tools: probably fix ff test flake * [1015a805](oxidecomputer/console@1015a805) tools: bump client generator, turn on noUnusedParameters in tsconfig
oxidecomputer/console@72e2f0c...f52f50c * [f52f50c7](oxidecomputer/console@f52f50c7) react 19.1 * [d0999667](oxidecomputer/console@d0999667) oxidecomputer/console#2773 * [e7bfb236](oxidecomputer/console@e7bfb236) oxidecomputer/console#2767 * [59e69764](oxidecomputer/console@59e69764) oxidecomputer/console#2768 * [44157459](oxidecomputer/console@44157459) oxidecomputer/console#2770 * [5a90b430](oxidecomputer/console@5a90b430) oxidecomputer/console#2769 * [c12696c0](oxidecomputer/console@c12696c0) make api-diff use latest generator * [5538906c](oxidecomputer/console@5538906c) oxidecomputer/console#2760 * [653ba4cb](oxidecomputer/console@653ba4cb) bump omicron for instance affinity groups list * [179f347f](oxidecomputer/console@179f347f) oxidecomputer/console#2766 * [dbaeb3d3](oxidecomputer/console@dbaeb3d3) oxidecomputer/console#2765 * [549c266e](oxidecomputer/console@549c266e) oxidecomputer/console#2762 * [d41ef17f](oxidecomputer/console@d41ef17f) oxidecomputer/console#2763 * [a5804f8f](oxidecomputer/console@a5804f8f) oxidecomputer/console#2761 * [fb2fdbec](oxidecomputer/console@fb2fdbec) oxidecomputer/console#2759 * [9de391c8](oxidecomputer/console@9de391c8) chore: playwright 1.51.1 came out like an hour later * [b49f70c0](oxidecomputer/console@b49f70c0) oxidecomputer/console#2757 * [3eb24d2d](oxidecomputer/console@3eb24d2d) chore: bump playwright to 1.51 * [f29e4ea9](oxidecomputer/console@f29e4ea9) chore: bump vite + plugins, vitest, msw * [0f3408d0](oxidecomputer/console@0f3408d0) chore: bump oxlint to 0.16 * [f9931e03](oxidecomputer/console@f9931e03) tools: probably fix ff test flake * [1015a805](oxidecomputer/console@1015a805) tools: bump client generator, turn on noUnusedParameters in tsconfig
Just a quick start. I actually really like the tooltips Claude Code put in the column header but we'll need to think about a) the copy, and b) spreading them around consistently so it doesn't feel haphazard.
Screenshot of initial version on its own tab