Convert old charts to new style #2762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
david-crespo
changed the title
david-crespo
commented
Mar 22, 2025
| data: ChartDatum[] | undefined | ||
| title: string | ||
| width: number | ||
| height: number |
There was a problem hiding this comment.
We were passing height and width at every callsite but it had no effect, probably because the ResponsiveContainer was overriding it.
david-crespo
commented
Mar 22, 2025
| <div> | ||
| <h2 className="flex items-center gap-1.5 px-3 text-mono-sm text-default"> | ||
| {title} {unit && <span className="text-tertiary">({unit})</span>}{' '} | ||
| {(inRange.isPending || beforeStart.isPending) && <Spinner />} |
There was a problem hiding this comment.
The loading state is handled inside the chart. The logic needs to be improved, but the loading state does show up for these charts.
david-crespo
force-pushed
the
chart-style
branch
from
92de8a2 to
fe6d11e
Compare
* Tighten spacing and more consistent with other layouts * Proper chart spacing on silo page
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Apr 1, 2025
oxidecomputer/console@72e2f0c...f52f50c * [f52f50c7](oxidecomputer/console@f52f50c7) react 19.1 * [d0999667](oxidecomputer/console@d0999667) oxidecomputer/console#2773 * [e7bfb236](oxidecomputer/console@e7bfb236) oxidecomputer/console#2767 * [59e69764](oxidecomputer/console@59e69764) oxidecomputer/console#2768 * [44157459](oxidecomputer/console@44157459) oxidecomputer/console#2770 * [5a90b430](oxidecomputer/console@5a90b430) oxidecomputer/console#2769 * [c12696c0](oxidecomputer/console@c12696c0) make api-diff use latest generator * [5538906c](oxidecomputer/console@5538906c) oxidecomputer/console#2760 * [653ba4cb](oxidecomputer/console@653ba4cb) bump omicron for instance affinity groups list * [179f347f](oxidecomputer/console@179f347f) oxidecomputer/console#2766 * [dbaeb3d3](oxidecomputer/console@dbaeb3d3) oxidecomputer/console#2765 * [549c266e](oxidecomputer/console@549c266e) oxidecomputer/console#2762 * [d41ef17f](oxidecomputer/console@d41ef17f) oxidecomputer/console#2763 * [a5804f8f](oxidecomputer/console@a5804f8f) oxidecomputer/console#2761 * [fb2fdbec](oxidecomputer/console@fb2fdbec) oxidecomputer/console#2759 * [9de391c8](oxidecomputer/console@9de391c8) chore: playwright 1.51.1 came out like an hour later * [b49f70c0](oxidecomputer/console@b49f70c0) oxidecomputer/console#2757 * [3eb24d2d](oxidecomputer/console@3eb24d2d) chore: bump playwright to 1.51 * [f29e4ea9](oxidecomputer/console@f29e4ea9) chore: bump vite + plugins, vitest, msw * [0f3408d0](oxidecomputer/console@0f3408d0) chore: bump oxlint to 0.16 * [f9931e03](oxidecomputer/console@f9931e03) tools: probably fix ff test flake * [1015a805](oxidecomputer/console@1015a805) tools: bump client generator, turn on noUnusedParameters in tsconfig
david-crespo
added a commit
to oxidecomputer/omicron
that referenced
this pull request
Apr 1, 2025
oxidecomputer/console@72e2f0c...f52f50c * [f52f50c7](oxidecomputer/console@f52f50c7) react 19.1 * [d0999667](oxidecomputer/console@d0999667) oxidecomputer/console#2773 * [e7bfb236](oxidecomputer/console@e7bfb236) oxidecomputer/console#2767 * [59e69764](oxidecomputer/console@59e69764) oxidecomputer/console#2768 * [44157459](oxidecomputer/console@44157459) oxidecomputer/console#2770 * [5a90b430](oxidecomputer/console@5a90b430) oxidecomputer/console#2769 * [c12696c0](oxidecomputer/console@c12696c0) make api-diff use latest generator * [5538906c](oxidecomputer/console@5538906c) oxidecomputer/console#2760 * [653ba4cb](oxidecomputer/console@653ba4cb) bump omicron for instance affinity groups list * [179f347f](oxidecomputer/console@179f347f) oxidecomputer/console#2766 * [dbaeb3d3](oxidecomputer/console@dbaeb3d3) oxidecomputer/console#2765 * [549c266e](oxidecomputer/console@549c266e) oxidecomputer/console#2762 * [d41ef17f](oxidecomputer/console@d41ef17f) oxidecomputer/console#2763 * [a5804f8f](oxidecomputer/console@a5804f8f) oxidecomputer/console#2761 * [fb2fdbec](oxidecomputer/console@fb2fdbec) oxidecomputer/console#2759 * [9de391c8](oxidecomputer/console@9de391c8) chore: playwright 1.51.1 came out like an hour later * [b49f70c0](oxidecomputer/console@b49f70c0) oxidecomputer/console#2757 * [3eb24d2d](oxidecomputer/console@3eb24d2d) chore: bump playwright to 1.51 * [f29e4ea9](oxidecomputer/console@f29e4ea9) chore: bump vite + plugins, vitest, msw * [0f3408d0](oxidecomputer/console@0f3408d0) chore: bump oxlint to 0.16 * [f9931e03](oxidecomputer/console@f9931e03) tools: probably fix ff test flake * [1015a805](oxidecomputer/console@1015a805) tools: bump client generator, turn on noUnusedParameters in tsconfig
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at #2732, #2733, and #2737, I realized we'd benefit from simplifying the chart component, and one source of complexity was the fact that the non-OxQL system and silo utilization charts were styled differently. So here I bring them up to date with the new style and eliminate the props we were using to differentiate.
Before
After