V4.0.0 branch #854
Merged
V4.0.0 branch #854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Node 4 will no longer be supported, considered during development, or tested with. To migrate your code, upgrade to a newer major version of Node.
…ebsocket Disable ssl for websocket
## [3.11.1](v3.11.0...v3.11.1) (2018-09-28) ### Bug Fixes * **icp:** disabling ssl verification now works for websocket connection ([f8466c8](f8466c8))
fix typo in assistant v2 example
Drop node 4 support
…amples Update vis rec examples
BREAKING CHANGE: Support for the `api_key` parameter has been removed. For instances of Visual Recognition, use `iam_apikey` to authenticate.
…lease-9 Regenerate sdk release 9
# [3.12.0](v3.11.1...v3.12.0) (2018-10-10) ### Features * **discovery:** new parameters added to match updates to the service ([838b044](838b044))
BREAKING CHANGE: The Dialog service will no longer be available To migrate your code, use the Assistant v1 or v2 service.
BREAKING CHANGE: There is no more `index.ts` file, so importing with `require('watson-developer-cloud')` will no longer work.
To migrate your code, import only the services that you need, e.g. `require('watson-developer-cloud/speech-to-text/v1')`.
Using the file `sdk.ts` to export all of the services for browserification
Remove index file
…als` update ibm-cloud-sdk-core, which renames `getCredentials` to `getServiceCredentials` BREAKING CHANGE: These method renames are breaking changes. Update the method names to migrate your code.
BREAKING CHANGE: For `updateValue`, parameter `new_type` is changed to `new_value_type`. For `updateDialogNode`, parameter `new_type` is changed to `new_node_type`.
BREAKING CHANGE: Parameter `model_id` has been changed to `model` for the following methods: convertToHtml, classifyElements, extractTables, compareDocuments, deleteFeedback, getFeedback, createBatch, and updateBatch
BREAKING CHANGE: For `updateClassifier` and `createClassifier`, the parameter `{classname}_positive_examples` is changed to a map called `positive_examples` with classnames as keys.
See the migration guide, UPGRADE-4.0.md, for more information.
Codecov Report
@@ Coverage Diff @@
## master #854 +/- ##
==========================================
- Coverage 95.65% 89.54% -6.11%
==========================================
Files 2 26 +24
Lines 46 3519 +3473
Branches 2 303 +301
==========================================
+ Hits 44 3151 +3107
- Misses 2 357 +355
- Partials 0 11 +11
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch contains all of the work that has been done for major version 4.
This PR is huge but the vast majority of this code has already been reviewed and approved on its way into the protected
v4.0.0-branch.There are also a lot of commits but many of them contain the "breaking change" messages that will make it into the changelog.
I welcome any questions or feedback regarding the process of moving this code into
master