Monkey patch 102516 #2

dalejung · 2016-10-30T04:02:50Z

Really two issues.

Make the main.js webpack modules accessible from custom.js. I did this by just creating an export module that modifies the global IPython object.
The timing of custom.js. Previously, custom.js would be fully loaded before the notebook loaded. Since the notebook is now webpacked, custom.js loads async as the notebook is rendering. So you might monkey patch the correct objects, but the bind_events has already referenced the old function. I pushed the loading to a function that is called after custom.js.

Also, note that I had to change nbextension loading to never Promise.reject and to handle errors internally. Promise.all fails fast which means if a single nbextension 404s then other nbextensions get loaded after the notebook get loaded.

along with a minor whitespace inconsistency introduced in an earlier commit.

Add "Shutdown" item to Kernel menu

add event for finished execution of cell

typo introduced in unwebpackification

declare contents variable

Patch CodeMirror 5.22

* Edit notebook opens a notebook, Edit any other file type open it in a text editor * View only available for HTML files to disambiguate between “viewing” a notebook or text file (which is the same as editing it) and viewing an HTML file

without this, it is not possible to select any text using the mouse in the contents of the modal. For example: editing the notebook metadata JSON you end up just moving the whole box around instead of being able to select a portion of the JSON using the mouse.

drag modal dialogs by the header only

Make dialogs draggable

doc typos related with issue jupyter#2069

When a kernelspec is removed while a kernel spawned from it is in use the Running tab on the dashboards page errors and no longer shows any results. Fall back on using the kernel name from the session in this case so that users can see and terminate kernels.

Fix JS error on running notebooks tab

Welcome Message for Console and Terminal Output

Adds edit and view buttons

Prevent making releases with wrong version number that will confuse pip, or make sdists to appear more recent than wheels.

Enforce version number at build time.

remove reference to `nodejs-legacy`, since apt packages are usually too old, anyway

make `--user` the non-default option, given the prevalence of conda/virtual envs these days

minor updates to CONTRIBUTING installation instructions

This makes the high-res screenshots larger on a lower-res screen, but nbsphinx doesn't currently handle HTML <img> tags, so we need to use the Markdown format to show images in our docs. Closes jupytergh-2304

Use Markdown image references in example notebook

Move preact, preact-compat, and proptypes to bower

Likely a side-effect of using `.form-control()`

Remove drop shadow from Tag UI for consistency.

Explain how to use cell tags in changelog

only consider stream output for data rate limit

…rate Revert "only consider stream output for data rate limit"

Add latex button to dropdown

Remove cell toolbar reminder

Follow up from PR jupyter#2331

Remove addition of cell toolbar reminder

(cherry picked from commit eed0d86)

before notebook itself loads. Previously a single nbextension loading error would mess up loading since Promise.all fails fast.

* Add Binder * Build from source on Binder * Add support for notebook server extensions * Add notebook shim * Remove python from deps * Add templates to MANIFEST * Binder * Add matplotlib and numpy to Binder

dalejung mentioned this pull request Oct 30, 2016

Monkey patch #1

Closed

ivanov and others added 29 commits January 24, 2017 16:50

kernel halt confirmation dialog

95790be

rename Halt to Shutdown

03e410b

fix tests

051e430

along with a minor whitespace inconsistency introduced in an earlier commit.

Merge pull request jupyter#2070 from ivanov/halt-kernel

eb73920

Add "Shutdown" item to Kernel menu

Merge pull request jupyter#2061 from dkrenn/dkrenn/event-finished-exec

cd47dac

add event for finished execution of cell

Patch CodeMirror after bower install

0e38b00

declare contents variable

83a2e83

typo introduced in unwebpackification

Merge pull request jupyter#2073 from minrk/var-contents

5721d7c

declare contents variable

Merge pull request jupyter#2066 from jupyter/cm-up

393a04d

Patch CodeMirror 5.22

Adds edit and view buttons, jupyter#1752

482ea4b

Revise jupyter#1755

a7387b8

Update View and Edit conditions

b7dcae6

* Edit notebook opens a notebook, Edit any other file type open it in a text editor * View only available for HTML files to disambiguate between “viewing” a notebook or text file (which is the same as editing it) and viewing an HTML file

Create /view route, handler, and template

0034f2a

Use /view route for HTML files

224294c

Add test_view_html

3cbb570

Clean up

acf4fa8

Make dialogs draggable

3d7f0f2

show message only on dev

12688f2

Merge pull request jupyter#5 from ivanov/draggable-dialog

1088371

drag modal dialogs by the header only

Display "move" cursor within modal header

532a66b

Merge pull request jupyter#2076 from gnestor/draggable-dialog

ecc3ea0

Make dialogs draggable

doc typos related with issue jupyter#2069

7276986

Merge pull request jupyter#2077 from kikocorreoso/master

c75a9d8

doc typos related with issue jupyter#2069

Fix missing running kernels

87b5b2f

When a kernelspec is removed while a kernel spawned from it is in use the Running tab on the dashboards page errors and no longer shows any results. Fall back on using the kernel name from the session in this case so that users can see and terminate kernels.

Merge pull request jupyter#2078 from parente/fix-missing-kernelspec

fecab00

Fix JS error on running notebooks tab

trigger event change.Cell

1bc6e20

Merge pull request jupyter#2065 from jinmehta13/console-welcome-message

be5cf10

Welcome Message for Console and Terminal Output

Merge pull request jupyter#1905 from gnestor/pr/1755

39b756b

Adds edit and view buttons

Carreau and others added 24 commits March 16, 2017 17:02

Enforce version number at build time.

8aa04b9

Prevent making releases with wrong version number that will confuse pip, or make sdists to appear more recent than wheels.

Merge pull request jupyter#2302 from Carreau/pep440

0087065

Enforce version number at build time.

update nodejs installation instructions

f57b92d

remove reference to `nodejs-legacy`, since apt packages are usually too old, anyway

invert --user recommendation in CONTRIBUTING

885ebc3

make `--user` the non-default option, given the prevalence of conda/virtual envs these days

Merge pull request jupyter#2305 from minrk/contributing-tweak

94122d6

minor updates to CONTRIBUTING installation instructions

Use Markdown image references in example notebook

9f8158a

This makes the high-res screenshots larger on a lower-res screen, but nbsphinx doesn't currently handle HTML <img> tags, so we need to use the Markdown format to show images in our docs. Closes jupytergh-2304

Merge pull request jupyter#2313 from takluyver/i2304

003f553

Use Markdown image references in example notebook

Move preact, preact-compat, and proptypes to bower

b69509f

Merge pull request jupyter#2319 from gnestor/preact

200a58c

Move preact, preact-compat, and proptypes to bower

Explain how to use cell tags in changelog

d2c539f

Remove drop shadow from Tag UI for consistency.

fc0354e

Likely a side-effect of using `.form-control()`

Merge pull request jupyter#2324 from Carreau/tagui

ae2316a

Remove drop shadow from Tag UI for consistency.

Merge pull request jupyter#2323 from takluyver/chglog-how-to-tag

d1ad588

Explain how to use cell tags in changelog

Merge pull request jupyter#2293 from minrk/stream-data-rate

de61e20

only consider stream output for data rate limit

Revert "only consider stream output for data rate limit"

15341ac

Merge pull request jupyter#2326 from jupyter/revert-2293-stream-data-…

2b2d321

…rate Revert "only consider stream output for data rate limit"

Add latex button to dropdown

9b771de

Remove cell toolbar reminder

f2f9237

Merge pull request jupyter#2329 from mpacer/latex_export

ab92722

Add latex button to dropdown

Merge pull request jupyter#2331 from gnestor/celltoolbar-reminder

ece0a77

Remove cell toolbar reminder

Remove addition of cell toolbar reminder

e294313

Follow up from PR jupyter#2331

Merge pull request jupyter#2333 from takluyver/rm-celltoolbar-reminder

7bb3b82

Remove addition of cell toolbar reminder

release 5.0.0rc2

35c37c0

Back to development

e9c9c3a

dalejung force-pushed the monkey_patch_102516 branch from 65b9fc9 to ffaf67c Compare March 25, 2017 17:54

dalejung added 4 commits March 25, 2017 13:55

Added an export module to expose vars for monkey patching

0b9cb8b

(cherry picked from commit eed0d86)

resolved

85862fd

Move notebook loading after nbextensions

71a7fde

ENH: Handle extension errors internally to ensure nbextensions load

ffaf67c

before notebook itself loads. Previously a single nbextension loading error would mess up loading since Promise.all fails fast.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Monkey patch 102516 #2

Monkey patch 102516 #2

Uh oh!

dalejung commented Oct 30, 2016

Uh oh!

Uh oh!

Monkey patch 102516 #2

Are you sure you want to change the base?

Monkey patch 102516 #2

Uh oh!

Conversation

dalejung commented Oct 30, 2016

Uh oh!

Uh oh!