Skip to content

Conversation

@pull
Copy link

@pull pull bot commented Jan 7, 2022

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

@pull pull bot added the ⤵️ pull label Jan 7, 2022
Demonmasterlqx and others added 29 commits February 24, 2025 14:19
* Update Debugging-Tf2-Problems.rst

some command to launch debug demo is wrong and correct it

Signed-off-by: Demonmasterlqx <[email protected]>

* Update Debugging-Tf2-Problems.rst

Signed-off-by: Demonmasterlqx <[email protected]>

* Rename Using-URDF-with-Robot-State-Publisher.rst to Using-URDF-with-Robot-State-Publisher-py.rst

change name

Signed-off-by: Demonmasterlqx <[email protected]>

* Create Using-URDF-with-Robot-State-Publisher-cpp.rst

add cpp version

Signed-off-by: Demonmasterlqx <[email protected]>

* Update Using-URDF-with-Robot-State-Publisher-cpp.rst

add 
.. redirect-from::

    Tutorials/URDF/Using-URDF-with-Robot-State-Publisher

Signed-off-by: Demonmasterlqx <[email protected]>

* Update Using-URDF-with-Robot-State-Publisher-cpp.rst

Signed-off-by: Demonmasterlqx <[email protected]>

* Update Using-URDF-with-Robot-State-Publisher-cpp.rst

Polish my language



Signed-off-by: Demonmasterlqx <[email protected]>

* Update Using-URDF-with-Robot-State-Publisher-cpp.rst

add code comment

Signed-off-by: Demonmasterlqx <[email protected]>

* Update Using-URDF-with-Robot-State-Publisher-cpp.rst

fix format problems

Signed-off-by: Demonmasterlqx <[email protected]>

* White space help.

* Update source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst

Signed-off-by: Katherine Scott <[email protected]>

* Update source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst

Signed-off-by: Katherine Scott <[email protected]>

* Update source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst

Signed-off-by: Katherine Scott <[email protected]>

* Update source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst

Signed-off-by: Katherine Scott <[email protected]>

* Update source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst

Signed-off-by: Katherine Scott <[email protected]>

* Update source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst

Signed-off-by: Katherine Scott <[email protected]>

* Update source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst

Co-authored-by: Christophe Bedard <[email protected]>
Signed-off-by: Demonmasterlqx <[email protected]>

* Update source/Tutorials/Intermediate/URDF/Using-URDF-with-Robot-State-Publisher-cpp.rst

Co-authored-by: Christophe Bedard <[email protected]>
Signed-off-by: Demonmasterlqx <[email protected]>

* codespell

Signed-off-by: Alejandro Hernandez Cordero <[email protected]>

* Title underline too short

Signed-off-by: Alejandro Hernandez Cordero <[email protected]>

* make tutorials visible

Signed-off-by: Alejandro Hernandez Cordero <[email protected]>

---------

Signed-off-by: Demonmasterlqx <[email protected]>
Signed-off-by: Katherine Scott <[email protected]>
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
Co-authored-by: kscottz <[email protected]>
Co-authored-by: Christophe Bedard <[email protected]>
Co-authored-by: Alejandro Hernandez Cordero <[email protected]>
Sphinx doesn't seem to like an unclosed single-quote in the
console text, and prints a "Lexing literal_block" warning.
Fix that here by getting rid of the contraction.

Signed-off-by: Chris Lalancette <[email protected]>
Signed-off-by: Tomoya.Fujita <[email protected]>
* codespell ROS 2 documentation dictionary support.

Signed-off-by: Tomoya Fujita <[email protected]>

* add more ROS specific words in the dictionary.

Signed-off-by: Tomoya Fujita <[email protected]>

---------

Signed-off-by: Tomoya Fujita <[email protected]>
* Cleanup the Windows instructions for using conda/pixi.

Signed-off-by: Chris Lalancette <[email protected]>

* Feedback from review.

Signed-off-by: Chris Lalancette <[email protected]>

* More feedback from review.

Signed-off-by: Chris Lalancette <[email protected]>

* Add .\  to execute local executable

Signed-off-by: Shane Loretz <[email protected]>

---------

Signed-off-by: Chris Lalancette <[email protected]>
Signed-off-by: Shane Loretz <[email protected]>
Co-authored-by: Shane Loretz <[email protected]>
* Make Kilted dates this year.

* Fix on date.
* Sentence Checker

* Some edits

* Update About-Executors.rst

* More sentence breaks

* More cleanup

* More sentences

* Fix smart quotes

* fix group tag indent for ROSCon 2023 and 2024 contents. (#5016)

Signed-off-by: Tomoya Fujita <[email protected]>

* Clean up sentences II (white space changes only) (#5017)

* Exclude literals parts from bold parts in 'Ament Lint CLI Utilities' (#5024)

You can't do nested inline markup in RST:

**Can't do ``this`` in RST.**

The simplest solution is to just exclude the ``literal`` part.

Also, do some other minor fixes.

Signed-off-by: Christophe Bedard <[email protected]>

* remove --break-system-packages and address docker build warnings. (#5021)

* remove --break-system-packages and address docker build warnings.

Signed-off-by: Tomoya Fujita <[email protected]>

* add github workflow to test Dockerfile.

Signed-off-by: Tomoya Fujita <[email protected]>

* Revert "add github workflow to test Dockerfile."

This reverts commit 8686f18.

Signed-off-by: Tomoya Fujita <[email protected]>

---------

Signed-off-by: Tomoya Fujita <[email protected]>

* More

* Other sentence formatting (#5031)

* Add second dot to abbreviations
* Remove some random periods
* Escape some periods
* Convert some links
* Add formatted block

* Enable github/workflow to verify Dockerfile. (#5035)

Signed-off-by: Tomoya Fujita <[email protected]>

* Update Using-Node-Interfaces-Template-Class.rst (#5038)

Added missing ``Output:`` before the terminal output for consistency reasons

Signed-off-by: Nikos Tziaros <[email protected]>

* added Publishing-Messages-Using-YAML-Files.rst and edited Intermediat… (#5034)

* added Publishing-Messages-Using-YAML-Files.rst and edited Intermediate.rst

* Update source/Tutorials/Intermediate/Publishing-Messages-Using-YAML-Files.rst

Co-authored-by: Tomoya Fujita <[email protected]>
Signed-off-by: Nikos Tziaros <[email protected]>

* Update source/Tutorials/Intermediate/Publishing-Messages-Using-YAML-Files.rst

Co-authored-by: Tomoya Fujita <[email protected]>
Signed-off-by: Nikos Tziaros <[email protected]>

* Update source/Tutorials/Intermediate/Publishing-Messages-Using-YAML-Files.rst

Signed-off-by: Nikos Tziaros <[email protected]>

* Update source/Tutorials/Intermediate/Publishing-Messages-Using-YAML-Files.rst

Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Nikos Tziaros <[email protected]>

* Update source/Tutorials/Intermediate/Publishing-Messages-Using-YAML-Files.rst

Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Nikos Tziaros <[email protected]>

* Update source/Tutorials/Intermediate/Publishing-Messages-Using-YAML-Files.rst

Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Nikos Tziaros <[email protected]>

* Update source/Tutorials/Intermediate.rst

Thanks for pointing it out, I didnt notice the extention beeing there

Co-authored-by: Christophe Bedard <[email protected]>
Signed-off-by: Nikos Tziaros <[email protected]>

* Update source/Tutorials/Intermediate/Publishing-Messages-Using-YAML-Files.rst

Co-authored-by: Christophe Bedard <[email protected]>
Signed-off-by: Nikos Tziaros <[email protected]>

---------

Signed-off-by: Nikos Tziaros <[email protected]>
Co-authored-by: Tomoya Fujita <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Co-authored-by: Christophe Bedard <[email protected]>

* more bits

* Some rollbacks

* Ignore

* Use sphinx_tamer

* More Sphinx Config

* Updated checker using subprocess

* Make sphinx-lint-with-ros exit with non-zero error codes

Signed-off-by: Shane Loretz <[email protected]>

* Wrap r2d2.rviz in backticks

Signed-off-by: Shane Loretz <[email protected]>

* Wrap URL in RST link

Signed-off-by: Shane Loretz <[email protected]>

* Add empty line after section title

Co-authored-by: Christophe Bedard <[email protected]>
Signed-off-by: Shane Loretz <[email protected]>

* Add empty line after section title

Co-authored-by: Christophe Bedard <[email protected]>
Signed-off-by: Shane Loretz <[email protected]>

* Use normalized project name sphinx-tamer

Co-authored-by: Tomoya Fujita <[email protected]>
Signed-off-by: Shane Loretz <[email protected]>

* Make sentence checker ignore `.idl`

Co-authored-by: Tomoya Fujita <[email protected]>
Signed-off-by: Shane Loretz <[email protected]>

---------

Signed-off-by: Tomoya Fujita <[email protected]>
Signed-off-by: Christophe Bedard <[email protected]>
Signed-off-by: Nikos Tziaros <[email protected]>
Signed-off-by: Shane Loretz <[email protected]>
Signed-off-by: Shane Loretz <[email protected]>
Co-authored-by: Tomoya Fujita <[email protected]>
Co-authored-by: Christophe Bedard <[email protected]>
Co-authored-by: Nikos Tziaros <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Co-authored-by: Christophe Bedard <[email protected]>
Co-authored-by: Shane Loretz <[email protected]>
Co-authored-by: Shane Loretz <[email protected]>
* add note for ros2 topic hz/bw.

Signed-off-by: Tomoya Fujita <[email protected]>

* address review comments.

Signed-off-by: Tomoya Fujita <[email protected]>

---------

Signed-off-by: Tomoya Fujita <[email protected]>
* Action Introspection introduction and tutorial.

Signed-off-by: Tomoya Fujita <[email protected]>

* address review comments.

Signed-off-by: Tomoya Fujita <[email protected]>

---------

Signed-off-by: Tomoya Fujita <[email protected]>
* docs: initial update

* docs: update-environment-hooks

* chore: lint fixes

* chore: update doc as per PR comments

* chore: update PR review comments

* chore: update gitignore

* docs: update docs for automatic spellcheck

* chore: update as per PR comments

* chore: update as per PR comments

---------

Co-authored-by: SuperGops7 <[email protected]>
Support for anon substitution was added in
ros2/launch#384 and is available from ROS2 foxy.
* Add Emerson Knapp to list of ROS Committers

I'm an approved committer on:
ros-tooling/keyboard_handler
ros-visualization/rqt_bag
ros2/rcl
ros2/rclcpp
ros2/rclpy
ros2/rosbag2
ros2/rosidl
ros2/rosidl_typesupport
ros2/rosidl_typesupport_fastrtps



Signed-off-by: Emerson Knapp <[email protected]>

* Alphasort

---------

Signed-off-by: Emerson Knapp <[email protected]>
ygerlach and others added 30 commits September 19, 2025 19:43
Use `$UBUNTU_CODENAME` if available

Signed-off-by: Yannis Gerlach <[email protected]>
* Fix: Correct URDF path in demo_launch.py 

This pull request resolves a launch file error by correcting the path used to find the robot's URDF file. The previous configuration was causing a TypeError because FindPackageShare was being called with too many arguments.

The correct implementation separates the package name from the file path, allowing PathJoinSubstitution to correctly combine them. This ensures the robot_state_publisher can successfully locate and load the r2d2.urdf.xml file.

Signed-off-by: Hemand Sunny <[email protected]>
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Skyler Medeiros <[email protected]>
* Cosmetic fixes for Developer Guide.

Signed-off-by: Tomoya.Fujita <[email protected]>

* add link anchor for target platforms and architectures.

Signed-off-by: Tomoya.Fujita <[email protected]>

* use internal doc link for ROS PMC constituents and committers.

Signed-off-by: Tomoya.Fujita <[email protected]>

---------

Signed-off-by: Tomoya.Fujita <[email protected]>
Signed-off-by: Tomoya.Fujita <[email protected]>
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
Signed-off-by: Luis Javier Arizmendi Alonso <[email protected]>
Co-authored-by: Scott K Logan <[email protected]>
Signed-off-by: Christoph Fröhlich <[email protected]>
These plugins are all installed via rosdep in Kilted and newer.

Signed-off-by: Scott K Logan <[email protected]>
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
* add script to find connext installations and add instruction to install dependencies when building from source

Signed-off-by: jncfa <[email protected]>

* implemented suggestions from review, added note regarding different shells

Signed-off-by: jncfa <[email protected]>

---------

Signed-off-by: jncfa <[email protected]>
* Update URDF-Main.rst



* Update URDF-Main.rst



* Update URDF-Main.rst



* Update URDF-Main.rst



* Update source/Tutorials/Intermediate/URDF/URDF-Main.rst




---------



(cherry picked from commit 645abee)

Signed-off-by: Arashdeep Singh <[email protected]>
Co-authored-by: Arashdeep Singh <[email protected]>
Co-authored-by: Tomoya Fujita <[email protected]>
#5916)

* Revert "Revert "Minor RTI Connext DDS documentation improvements (#5606)" (#5915)"

This reverts commit 8f7d0c4.

Signed-off-by: Tomoya.Fujita <[email protected]>

* fix lint error, one sentence per line.

Signed-off-by: Tomoya.Fujita <[email protected]>

---------

Signed-off-by: Tomoya.Fujita <[email protected]>
Signed-off-by: Nils-Christian Iseke <[email protected]>
Signed-off-by: Christophe Bedard <[email protected]>
Co-authored-by: Christophe Bedard <[email protected]>
Signed-off-by: Christophe Bedard <[email protected]>
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Christophe Bedard <[email protected]>
Co-authored-by: gavanderhoorn <[email protected]>
Co-authored-by: William Woodall <[email protected]>
Co-authored-by: Chris Lalancette <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
* Revert "Enable Zenoh router to make the post-install example work (#5858)"

This reverts commit b684b72.

* Revert "Enable zenohd to make the post-install example work for Ubuntu Debian. (#5860)"

This reverts commit 86d8c1a.

* Added link to RMW implementations page.
…pp_components_register_nodes (#5984)

Signed-off-by: Maurice <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.